Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] firewall management - update_rule_group - "version" should be renamed to "tracking" #1106

Open
GabrielNBJJ opened this issue Jan 25, 2024 · 1 comment
Assignees
Labels
API usage General API usage issues and questions bug 🐛 Something isn't working firewall Firewall Policies and Management issues and questions

Comments

@GabrielNBJJ
Copy link

Describe the bug
When trying to call the update_rule_group API call, we get prompt with something like

update_response = falcon.update_rule_group(
    id=rule_group_id,
    comment="Removing a rule",
    rule_ids=updated_rule_ids,
    rule_versions=updated_rule_versions,
    diff_operations=[diff_operation],
    diff_type="application/json-patch+json"}

we receive a response similar to

'errors': [{'code': 400, 'message': "rule group 'version' cannot be empty"}]}

'version' actually refers to the "tracking" token from the rule group. This should be renamed as version is misleading.

@GabrielNBJJ GabrielNBJJ added the bug 🐛 Something isn't working label Jan 25, 2024
@jshcodes jshcodes self-assigned this Jan 25, 2024
@jshcodes
Copy link
Member

jshcodes commented Jan 25, 2024

Hi @GabrielNBJJ -

We've investigated this issue and it appears to be a problem with how this error is generated. You are correct, the value that should be provided here is the tracking argument. We are resolving this on the API side.

Thank you for reporting this issue! 😄

@jshcodes jshcodes added API usage General API usage issues and questions firewall Firewall Policies and Management issues and questions labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API usage General API usage issues and questions bug 🐛 Something isn't working firewall Firewall Policies and Management issues and questions
Projects
None yet
Development

No branches or pull requests

2 participants