Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream error "json: invalid number literal, trying to unmarshal "\"DOMAIN_COMPROMISE\"" into Number" #215 #219

Closed
kliao365 opened this issue Apr 18, 2022 · 1 comment · Fixed by #221

Comments

@kliao365
Copy link

Hi,

It looks like #216 doesn't fix the issue #215. The same error "json: invalid number literal, trying to unmarshal ""DOMAIN_COMPROMISE"" into Number" is still happening. Perhaps the CrowdStrike API could contain "DOMAIN_COMPROMISE" as a value for the Event.IncidentType field and declaring the type of Event.IncidentType as json.Number can't handle non numerical strings like "DOMAIN_COMPROMISE". Your help to address this issue is much appreciated.

Kevin

@isimluk
Copy link
Contributor

isimluk commented Apr 20, 2022

Hello @kliao365,

You are right, I misread the root cause of your original report. Should be fixed in #221.

Thank You for your patience with me.
Simon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants