Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the search result UI to the search suggest UI #414

Closed
wants to merge 12 commits into from
Closed

Adjust the search result UI to the search suggest UI #414

wants to merge 12 commits into from

Conversation

lightnet328
Copy link
Member

Overview

Adjust the search result UI to the search suggest UI in order to ensure consistency.

Changes

  • Adjusted the search result UI to the search suggest UI
  • Search results is limited to 50 cases for each group
    • Click the more button to see more results
  • Pages will be "sticky" when scrolled
    • Screen 3

Screens

Before

2019-01-25 14 21 46

After

2019-01-25 14 12 07
2019-01-25 14 27 45

  • The number of displayed results has been reduced from 50 to 10 in order to show the more button in these screenshots.

@sotarok sotarok temporarily deployed to crowi-dev-pr-414 January 25, 2019 05:39 Inactive
@sotarok sotarok temporarily deployed to crowi-dev-pr-414 January 25, 2019 05:56 Inactive
@lightnet328 lightnet328 mentioned this pull request Feb 20, 2019
Open
@sotarok sotarok added this to the v1.8.0 milestone Jul 2, 2019
@lightnet328 lightnet328 changed the base branch from master to dev/v1.8 July 18, 2019 15:57
@lightnet328 lightnet328 closed this Aug 6, 2019
@lightnet328
Copy link
Member Author

Close because the search result list cannot be displayed correctly on mobile

@lightnet328 lightnet328 deleted the improve/sticky-search-result branch September 8, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sotarok sotarok Awaiting requested review from sotarok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lightnet328 @sotarok