Migrate comment to React #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super nice. |
Conflicts: client/app.js client/app.tsx client/crowi.js client/crowi.ts lib/views/widget/page_side_content.html
lightnet328
force-pushed
the
refactor/react-comments
branch
from
60976b7
to
ad34b4b
Compare
lightnet328
force-pushed
the
refactor/react-comments
branch
from
ad34b4b
to
5cdeb5f
Compare
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 35.17% 35.28% +0.11%
==========================================
Files 112 112
Lines 4543 4557 +14
Branches 700 702 +2
==========================================
+ Hits 1598 1608 +10
- Misses 2319 2321 +2
- Partials 626 628 +2
Continue to review full report at Codecov.
|
sotarok
requested changes
Aug 14, 2019
| <> | ||
| <CommentList className="collapse" id="page-comments-list-newer" crowi={crowi} comments={comments} revisionId={revisionId} /> | ||
| <a className="text-center" data-toggle="collapse" href="#page-comments-list-newer"> | ||
| <i className="fa fa-angle-double-up" /> Comments for Newer Revision <i className="fa fa-angle-double-up" /> |
There was a problem hiding this comment.
❌ fa is no longer valid.
Use Common/Icon instead.
lightnet328
force-pushed
the
refactor/react-comments
branch
from
b3466dd
to
7f3197e
Compare
sotarok
approved these changes
Aug 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There is no major change in appearance or feature, and the comment feature was migrated to React.
Changes
Depends on
#420