Reload fields depends on config even when config updated in another node #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otofune
force-pushed
the
reload-when-config-chenge-notified-by-pubsub
branch
from
9f27f7a
to
68a6f5a
Compare
otofune
commented
Jun 6, 2019
| if (channel !== this.configPubSubChannel) return | ||
| const { pubSubId, config } = JSON.parse(message) | ||
| if (pubSubId === this.pubSubId) return | ||
| this.config = config | ||
| await Promise.all([this.setupSlack(), this.setupMailer()]) |
There was a problem hiding this comment.
[note] I thought that it's bit difficult to detect what instances to reload by difference from current config. Also it will confuse someone reading this.
This is why of adding this only.
There was a problem hiding this comment.
Also I checked that there are no problem to call setupSlack and setupMailer always.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#8 was resolved by #435. But it doesn't include reloading some instances that depends on config.
This PR adds it.