-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dev env packages. #695
Conversation
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
==========================================
+ Coverage 22.42% 22.45% +0.02%
==========================================
Files 268 268
Lines 7549 7548 -1
Branches 1154 1154
==========================================
+ Hits 1693 1695 +2
+ Misses 4780 4777 -3
Partials 1076 1076
Continue to review full report at Codecov.
|
"eqeqeq": "off", | ||
"camelcase": "off", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll fix these off
s step by step.
@@ -93,7 +93,7 @@ export default class CrowiRenderer { | |||
result = code | |||
} | |||
|
|||
result = escape ? result : Crowi.escape(result, true) | |||
result = escaped ? result : Crowi.escape(result, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a bug ...
"typescript": "^3.7.3" | ||
"ts-jest": "^26.1.1", | ||
"ts-node": "^8.10.2", | ||
"typescript": "^3.8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgraded typescript not to 3.9 but 3.8, because of webpack/webpack/issues/10227
Upgrade: