remove clean-fid
#38
Closed
remove clean-fid
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `clean-fid` library has an old version of `requests` pinned in its dependencies that's currently causing me some headaches. I see a couple discussions related to replacing/reimplementing `clean-fid` (crowsonkb#7 and crowsonkb#8), and I don't see any imports related to it in the current code, so I was wondering if you'd be open to removing it from the requirements file for the next release. Feel free to close this if not; just thought I'd check. Thanks!
|
I'm still using |
|
Whoops; I must've searched for usages of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clean-fidlibrary has an old version ofrequestspinned in its dependencies that's currently causing me some headaches.I see a couple discussions related to replacing/reimplementing
clean-fid(#7 and #8), and I don't see any imports related to it in the current code, so I was wondering if you'd be open to removing it from the requirements file for the next release. Feel free to close this if not; just thought I'd check.Thanks!