Skip to content

Commit

Permalink
secscan: continue iterating after failure (PROJQUAY-2563) (quay#892)
Browse files Browse the repository at this point in the history
If Clair returns an error the current behaviour is to
error out, thus not indexing any subsequent manifests.
This change allows the worker to continue indexing
subsequent manifests after one failure.

Signed-off-by: crozzy <joseph.crosland@gmail.com>
  • Loading branch information
crozzy committed Sep 17, 2021
1 parent 0f7fdb7 commit 694fa2a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions data/secscan_model/secscan_v4_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,10 +289,10 @@ def mark_manifest_unsupported(manifest):
except InvalidContentSent as ex:
mark_manifest_unsupported(manifest)
logger.exception("Failed to perform indexing, invalid content sent")
return None
continue
except APIRequestFailure as ex:
logger.exception("Failed to perform indexing, security scanner API error")
return None
continue

with db_transaction():
ManifestSecurityStatus.delete().where(
Expand Down

0 comments on commit 694fa2a

Please sign in to comment.