Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for 1.19.4 #68

Closed
wants to merge 1 commit into from
Closed

feat: support for 1.19.4 #68

wants to merge 1 commit into from

Conversation

Vortezz
Copy link

@Vortezz Vortezz commented May 31, 2023

Little pull request to add support for 1.19.4

@crpmax
Copy link
Owner

crpmax commented Jun 1, 2023

The chat is not working.

When I typed a chat message, it kicked the bot with:
[Server thread/INFO]: 5qjQ8p5J5X9JBP1S lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java.lang.IndexOutOfBoundsException: readerIndex(22) + length(256) exceeds writerIndex(26): PooledUnsafeDirectByteBuf(ridx: 22, widx: 26, cap: 26)

Only chat commands work.

The next problem is that the disconnect message is empty.

[12:34:35] INFO | N3R9PQvlNbZZEBwT disconnected
[12:34:35] INFO |  ->

PLEASE TEST YOUR CODE BEFORE CREATING A PULL REQUEST!

I tested it on Spigot 1.19.4.

@Vortezz
Copy link
Author

Vortezz commented Jul 20, 2023

The code was working on spigot 1.19.4 with chat messages because I tested it too....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants