-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.20.4 #84
base: main
Are you sure you want to change the base?
1.20.4 #84
Conversation
have you been able to successfully compile it ? this is what i get it seems that mcprotocollib to 1.20.4-2-SNAPSHOT requires java 17 when the rest of this project uses java 8 to compile, I don't know how to set gradle to fix the issue, I think you have to change the following settings in build.gradle from: To: or just '17' at each, the last one worked for me after I found a issue with my java_Home path... |
Yes, it seems like Java 17 is required. I will look into it and maybye upgrade it to Java 17 if there is no other solution. |
i was able to compile it yesterday and get it to run with no issue, but had to do both with java 17, java 8 doesn't want to work with it, the main reason I found for the major change with that is that the new mcprotocollib has a class that's written exclusively in java 17. |
yes like most modern minecraft related tools and libraries require java 17. Like maybe just use java 17. java 8 is too old at this point. |
pls add |
+1 to this, Minecraft 1.20.4 requires Java 17 at this point, so it is most likely that the user will have Java 17 installed on their system. I have a 1.20.4 Paper server and I would like to test the plugin with this software. |
After changing sourceCompatibility and targetCompatibility to 17, it does compile and run, |
updated mcprotocollib to 1.20.4-2-SNAPSHOT
added net.kyori:adventure-text-serializer-gson:4.16.0
as dependency because when building without it it gave error because the version that mcprotcollib used was not available.