Merge pull request #565 from crsh/issue559

Solves issue #559

R/apa_num.R

@@ -430,12 +430,13 @@ print_p <- apa_p
 #'   should be determined for each element of `x` separately (the default),
 #'   or for the complete vector `x`.
 #' @inherit apa_num return
+#' @inheritParams base::formatC
 #' @seealso [apa_num()], [apa_p()]
 #' @examples
 #' apa_df(c(1, 1.23151))
 #' @export
 
-apa_df <- function(x, digits = 2L, elementwise = TRUE) {
+apa_df <- function(x, digits = 2L, big.mark = "", elementwise = TRUE) {
 
   if(is.null(x))    return(NULL)
   if(is.integer(x)) return(apa_num(x))
@@ -455,7 +456,7 @@ apa_df <- function(x, digits = 2L, elementwise = TRUE) {
     digits <- 0L
   }
 
-  apa_num(x, digits = digits)
+  apa_num(x, digits = digits, big.mark = big.mark)
 }
 
 #' @rdname apa_df

inst/NEWS.md

@@ -1,6 +1,11 @@
+# Upcoming release
+
+- Degrees of freedom are now (as a new default) reported without a comma as a big mark, resolves #559 reported by @Fritz-theCat.
+
+
 # papaja 0.1.1
 
-- Maintenance update: Adjuted unit tests to avoid removal from CRAN
+- Maintenance update: Adjusted unit tests to avoid removal from CRAN
 
 # papaja 0.1.0
 

tests/testthat/test_apa_num.R

@@ -268,3 +268,19 @@ test_that(
     )
   }
 )
+
+test_that(
+  "apa_df() respects big.mark"
+  , {
+    # default
+    expect_identical(
+      apa_df(1e4)
+      , "10000"
+    )
+    # with other argument
+    expect_identical(
+      apa_df(1e4, big.mark = "{,}")
+      , "10{,}000"
+    )
+  }
+)