Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes outdated test for apa_table(). Fixes #563 #566

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

crsh
Copy link
Owner

@crsh crsh commented Sep 27, 2023

As pointed out by @yihui, there we had an outdated test for apa_table() that is no longer required because the tested argument has been removed.

As reported in #563, this test is causing issues for the development version of knitr.

This PR removes the test and should resolve the issue in knitr. The tests are failing due to an unrelated issue.

Copy link
Collaborator

@mariusbarth mariusbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks just fine

@yihui
Copy link

yihui commented Sep 27, 2023

Thank you! I'll truly appreciate it if you can make a new CRAN release in the next few months.

@mariusbarth mariusbarth merged commit 23d7a31 into main Sep 27, 2023
4 of 5 checks passed
@crsh
Copy link
Owner Author

crsh commented Oct 4, 2023

@yihui, the update is now available on CRAN.

@yihui
Copy link

yihui commented Oct 4, 2023

Great! Thank you!

yihui added a commit to yihui/knitr that referenced this pull request Oct 4, 2023
clrpackages pushed a commit to clearlinux-pkgs/R-knitr that referenced this pull request Oct 30, 2023
Christophe Dervieux (4):
      escape `fig.alt` for HTML output (#2291)
      close #2295: use a warning instead of an error for `opts_current` locking (#2296)
      Improve convert_chunk_header() for YAML options (#2300)
      Probably need to use the higher dependency gridSVG that requires XML not available on R 3.6.0

Pedro Faria (1):
      close #2226: add an error handler to improve YAML error message (#2294)

Yihui Xie (12):
      start the next version
      give users the key to unlock opts_current in the error message (yihui/knitr#1798)
      simplify this clumsy decade-old JS code
      the new version of papaja is on CRAN now: crsh/papaja#566
      fix #2288: preserve the minus sign when formatting negative numbers -10^n
      revise c1c9a5766a632fcb535fc432c7be401cba965c22 and ca7172752b6a3b4a5d2d9492e21844adad20198d: just don't use simple progress bars in RStudio, no matter where they are
      lingglosses v0.0.7 is on CRAN
      fix rstudio/rmarkdown#2518: when fig.num is a multiple of fig.ncol, add \newline to the last subfigure
      restore `opts_current` after each code chunk, and also after `knit()` exits (#2292)
      fix #2302: wrap figure output in raw latex blocks for Markdown output (#2303)
      revert 4307aedad27ec04defa35bf21d578feecd10665e and fix #2302 by escaping % instead
      CRAN release v1.45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants