Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong default running head in DOCX on p. > 1 #567

Merged
merged 3 commits into from
Sep 27, 2023
Merged

Conversation

crsh
Copy link
Owner

@crsh crsh commented Sep 27, 2023

In a recent update of the DOCX template, I regenerated this file from our example manuscript. In the process I forgot to set the running head on pages > 2 to TITLE, which would be replaced by the correct short title in the postprocessor. Hence the short title of the example manuscript was used in every generated file... yikes
(see #561)!

This should be fixed by this PR.

Copy link
Collaborator

@mariusbarth mariusbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approval

Merge branch 'main' into crsh/issue561

# Conflicts:
#	inst/NEWS.md
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5e99272) 81.96% compared to head (7eed94b) 81.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   81.96%   81.96%           
=======================================
  Files          45       45           
  Lines        4224     4224           
=======================================
  Hits         3462     3462           
  Misses        762      762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariusbarth mariusbarth merged commit f774c98 into main Sep 27, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants