-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS Review 1 #52
Comments
Hi @pierrerogy @xuanxu , I'm Yizhou, one of the authors of this app. Thank you so much for the constructive comments on our work. I'll use them to improve our work and submit a more completed version later. By the way, are there any deadlines for us to resubmit our revised work? |
Echoing Yizhou, thanks so much for the constructive feedback! |
We thank the reviewers for such helpful comments that have greatly improved the web apps and the manuscript. All of our changes are in the review branch which we will merge to master after approval by the reviewers and editorial team. Review 1Functionality and Documentation:
Software paper
|
Hello!
First, great job on the apps, they look great and I am sure they will indeed be a fundamental step in teaching data science. I found the documentation thorough and clear, and the apps engaging and fun to use. Please find below my comments associated with the checklist in the JOSS review. Please let me know if you have any questions!
General checks
Everything looks good!
Functionality & Documentation
I was able to download the repo successfully using the provided command. However, I had several issues with the rest of the provided code.
thatssorandom
is not available on at least the two most recent versions of R, so I had to useinstall.github(“https://github.com/EdwinTh/thatssorandom")
to get it and use the appsshiny::runApp("/path/to/wi-fast-stats")
). I think the first issue here is that the repo downloads asfast-stats
and notwi-fast-stats
. Then, the provided command should directly point to the folder where one of the app is present inshiny-app/
.In terms of the app functionnality, I only have two main comments (only using sample data):
Software paper
Best of luck on the rest, and can't wait to see this project completed!
Pierre
The text was updated successfully, but these errors were encountered: