Fixes re-initialization upon adding inlines #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the rationale is that the elements an event are bound to must exist. this isn't the case for the specified selectors. i'd appreciate if this was released soon. solves #87
|
the failed tests seem to relate to Py3.2. i'm not sure if it is still supported anyway. |
|
Hm. It seems to be an error in pip for 3.2 I can't find anything about Django not supporting 3.2. Have they dropped that ? |
|
The PR looks good. That's the correct solution I think. Thanks |
crucialfelix
added a commit
that referenced
this pull request
Feb 3, 2016
Fixes re-initialization upon adding inlines
|
i don't know exactly the status of Py3.2, just noticed that it often fails in testsuites or isn't tested at all. can you anticipate when this bug fix will be available via the PyPI? |
|
I'm not quite sure yet. Very busy at the moment (2 clients and a new born baby). If you need to deploy right away you can always use a github link with pip. |
|
a'ight, all the best with the new one! sure, we can use a link to the repo. and keep in mind to change it later. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the rationale is that the elements an event are bound to must exist. this isn't the case for the specified selectors.
i'd appreciate if this was released soon.
solves #87