dj21 render() has a new param: renderer #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. |
…ure arguments too
|
Hi, do you have idea when this fix will be released ? Thank you :) |
|
As I'm on vacation right now, not until August 20th at the earliest. Sorry.
I haven't tested it yet and need to figure out why unit tests didn't fail
if this was really a breaking change.
You can install python packages from a git URL.
…On Mon, Aug 6, 2018, 16:44 kornikopic ***@***.***> wrote:
Hi, do you have idea when this fix will be released ? Thank you :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#235 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANWcgj27c5H6HC5T5yzHOr-Nf0sjkuiks5uOFZjgaJpZM4VX6dh>
.
|
|
No problem, thank you for the quick follow up. Enjoy your holidays! |
|
Maybe I am not good with pip but it seems that @zvolsky's branch is not working. Here is the command I executed:
|
|
Do you mean that you cannot check it out, or that it isn't working
correctly.
I think it would actually require the dist to be made.
I'll see if I can test and release on the 19th or 20th
…On Tue, Aug 14, 2018, 03:43 kornikopic ***@***.***> wrote:
Maybe I am not good with pip but it seems that @zvolsky
<https://github.com/zvolsky>'s branch is not working.
Here is the command I executed:
pip install -e git+git://
***@***.***_fix_renderer#egg=django-ajax-selects
Pip freeze gives me this output:
-e git://
***@***.***#egg=django_ajax_selects
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#235 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANWcvlFkjA2nuutdrDQaCybxnT0jb9Mks5uQitOgaJpZM4VX6dh>
.
|
|
It gives me the same error as previously mentioned. That's why I published the command I executed because I don't understand why it still not working. Maybe @zvolsky forgot some places? I'm at work right now but as soon as I'm back home, I'll post the exact error message I got. |
|
Tomorrow morning I'll get this solved and released. Big client work today. Thanks for your patience. |
|
Thanks a lot for your support. |
|
Thanks very much for the PR ! The tests now run against all versions and they do check all the render() of fields. Doing the release shortly. |
|
Working great for me with django 2.1. Thank you! |
|
@crucialfelix Thank you for the release but it still does not work for me. Here is the stacktrace: Here is the portion of the code that I use for the Ajax Select: form = make_ajax_form(BusinessLocation, {
'city': 'cities',
'postal_code': 'postal_codes'
})The Lookups: @register('cities')
class CityLookup(LookupChannel):
model = City
def get_query(self, q, request):
return self.model.objects.filter(name__istartswith=q)
@register('postal_codes')
class PostalCodeLookup(LookupChannel):
model = PostalCode
def get_query(self, q, request):
return self.model.objects.filter(postal_code__istartswith=q) |
|
@crucialfelix Nevermind. I found the problem. I was using another plugin in my form on another field. Everything's working perfectly! Thank you again for your support and the release. |
|
Damn... Oh ok... Great ! Glad to hear it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this under dj21rc1:
Traceback (most recent call last):
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/core/handlers/base.py", line 156, in _get_response
response = self.process_exception_by_middleware(e, request)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/core/handlers/base.py", line 154, in _get_response
response = response.render()
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/response.py", line 106, in render
self.content = self.rendered_content
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/response.py", line 83, in rendered_content
content = template.render(context, self._request)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/backends/django.py", line 61, in render
return self.template.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 171, in render
return self._render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 163, in _render
return self.nodelist.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 937, in render
bit = node.render_annotated(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/loader_tags.py", line 150, in render
return compiled_parent._render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 163, in _render
return self.nodelist.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 937, in render
bit = node.render_annotated(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/loader_tags.py", line 150, in render
return compiled_parent._render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 163, in _render
return self.nodelist.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 937, in render
bit = node.render_annotated(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/loader_tags.py", line 150, in render
return compiled_parent._render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 163, in _render
return self.nodelist.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 937, in render
bit = node.render_annotated(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/loader_tags.py", line 62, in render
result = block.nodelist.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 937, in render
bit = node.render_annotated(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/loader_tags.py", line 62, in render
result = block.nodelist.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 937, in render
bit = node.render_annotated(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/defaulttags.py", line 209, in render
nodelist.append(node.render_annotated(context))
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/loader_tags.py", line 188, in render
return template.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 173, in render
return self._render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 163, in _render
return self.nodelist.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 937, in render
bit = node.render_annotated(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/defaulttags.py", line 209, in render
nodelist.append(node.render_annotated(context))
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/defaulttags.py", line 209, in render
nodelist.append(node.render_annotated(context))
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/defaulttags.py", line 309, in render
return nodelist.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 937, in render
bit = node.render_annotated(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/defaulttags.py", line 309, in render
return nodelist.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 937, in render
bit = node.render_annotated(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 904, in render_annotated
return self.render(context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 993, in render
return render_value_in_context(output, context)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/template/base.py", line 972, in render_value_in_context
value = str(value)
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/utils/html.py", line 397, in
klass.str = lambda self: mark_safe(klass_str(self))
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/forms/boundfield.py", line 33, in str
return self.as_widget()
File "/home/vagrant/venv37/lib/python3.7/site-packages/django/forms/boundfield.py", line 93, in as_widget
renderer=self.form.renderer,
TypeError: render() got an unexpected keyword argument 'renderer'