-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 3 #255
Django 3 #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an entry to tox.ini
?
envlist:
py37-{dj20,dj21,dj30}
deps:
dj30: Django>=3,<3.1
That should run the tests against Django 3.0
Thank you so much!
Thanks for the feedback. Done and done! |
For some reason the test didn't actually run against Django 3: I will try it locally |
I'm looking at Django's tox.ini https://github.com/django/django/blob/stable/1.11.x/tox.ini I still haven't figured it out. |
I just had to add the environment to the |
when can we expect the release? |
I will do it tomorrow
…On Thu, Jan 16, 2020 at 3:40 PM Alexander Kiselyov ***@***.***> wrote:
when can we expect the release?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#255?email_source=notifications&email_token=AABVM4XDMZ23RAUHC5XY5WTQ6BWU7A5CNFSM4KEADLX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJEJFSQ#issuecomment-575181514>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABVM4VNMXTXQGDHURU66RDQ6BWU7ANCNFSM4KEADLXQ>
.
|
1.9.0 is out https://pypi.org/project/django-ajax-selects/ When I get a chance I will switch to Poetry for releases. |
This PR does the following for Django 3 compatibility:
django.utils.six
since it has been removed from django. Instead, addedsix
as a dependency and use it directly.ugettext_
withgettext_
if the python version is >= 3 (deprecated in Django 3).