Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 3 #255

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Django 3 #255

merged 3 commits into from
Jan 10, 2020

Conversation

theunraveler
Copy link
Contributor

This PR does the following for Django 3 compatibility:

  • Removes references to django.utils.six since it has been removed from django. Instead, added six as a dependency and use it directly.
  • Replaced ugettext_ with gettext_ if the python version is >= 3 (deprecated in Django 3).

Copy link
Owner

@crucialfelix crucialfelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an entry to tox.ini?

envlist:
  py37-{dj20,dj21,dj30}

deps:
  dj30: Django>=3,<3.1

That should run the tests against Django 3.0

Thank you so much!

ajax_select/fields.py Outdated Show resolved Hide resolved
@theunraveler
Copy link
Contributor Author

Thanks for the feedback. Done and done!

@crucialfelix
Copy link
Owner

For some reason the test didn't actually run against Django 3:
https://travis-ci.org/crucialfelix/django-ajax-selects/builds/634962562?utm_source=github_status&utm_medium=notification

I will try it locally

@crucialfelix
Copy link
Owner

I'm looking at Django's tox.ini https://github.com/django/django/blob/stable/1.11.x/tox.ini
and the docs: https://tox.readthedocs.io/en/latest/config.html

I still haven't figured it out.

@theunraveler
Copy link
Contributor Author

I just had to add the environment to the .travis.yml file. Looks good now.

@crucialfelix crucialfelix merged commit c72cc92 into crucialfelix:develop Jan 10, 2020
@theunraveler theunraveler deleted the django_3 branch January 10, 2020 22:31
@diverru
Copy link

diverru commented Jan 16, 2020

when can we expect the release?

@crucialfelix
Copy link
Owner

crucialfelix commented Jan 16, 2020 via email

@crucialfelix
Copy link
Owner

1.9.0 is out https://pypi.org/project/django-ajax-selects/

When I get a chance I will switch to Poetry for releases.
2.0.0 will be the next release and will drop support for python 2.
I can still release bug fixes for < 3 but I probably won't need to or want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants