Fix #247 CSS classes for jQuery click binding do not work for Django 2.1.3 #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crucialfelix
requested changes
Feb 4, 2020
There was a problem hiding this comment.
I didn't actually test this, but I'm pretty sure this is the case.
You can easily install and run the example app with different versions: https://github.com/crucialfelix/django-ajax-selects/blob/develop/example/README.md
| @@ -240,7 +240,7 @@ | |||
| $(window).trigger('init-autocomplete'); | |||
| // When adding new rows in inline forms, reinitialize and activate newly added rows. | |||
| $(document) | |||
| .on('click', '.inline-group ul.tools a.add, .inline-group div.add-row a, .inline-group .tabular tr.add-row td a', function() { | |||
| .on('click', '._inline-group ul.tools a.add, ._inline-group div.add-row a, ._inline-group .tabular tr.add-row td a', function() { | |||
There was a problem hiding this comment.
It needs to include both the old classes and the new ones. Only then will it work for all supported versions.
.inline-group ul.tools a.add, .inline-group div.add-row a, .inline-group .tabular tr.add-row td a, ._inline-group ul.tools a.add, ._inline-group div.add-row a, ._inline-group .tabular tr.add-row td a
|
Thanks for the PR! |
crucialfelix
changed the title
crucialfelix
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247