Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Django 3.2 and 4.0 deprecation warnings #289

Merged

Conversation

andyzickler
Copy link
Contributor

@andyzickler andyzickler commented Dec 18, 2021

  • Adds django 3.2 and 4.0 to tox
  • Setup tox to display all warnings
  • Fixes the following warnings:

RemovedInDjango40Warning: django-admin.py is deprecated in favor of django-admin.

tests/urls.py:11: RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path().
url(r'^ajax_lookups/', include(ajax_select_urls)),

tests.Author: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.
HINT: Configure the DEFAULT_AUTO_FIELD setting or the AppConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.

RemovedInDjango41Warning: 'ajax_select' defines default_app_config = 'ajax_select.apps.AjaxSelectConfig'. Django now detects this configuration automatically. You can remove default_app_config.

* Adds django 3.2 and 4.0 to tox
* Setup tox to display all warnings
* Fixes the following warnings:

RemovedInDjango40Warning: django-admin.py is deprecated in favor of django-admin.

tests/urls.py:11: RemovedInDjango40Warning: django.conf.urls.url() is deprecated in favor of django.urls.re_path().
  url(r'^ajax_lookups/', include(ajax_select_urls)),

tests.Author: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.
    HINT: Configure the DEFAULT_AUTO_FIELD setting or the AppConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.

RemovedInDjango41Warning: 'ajax_select' defines default_app_config = 'ajax_select.apps.AjaxSelectConfig'. Django now detects this configuration automatically. You can remove default_app_config.
@crucialfelix
Copy link
Owner

Hello! Thank you for this. I'm now back from vacation and will look at this as soon as I get a chance. Thanks again!

@andyzickler andyzickler mentioned this pull request Jan 8, 2022
@crucialfelix crucialfelix merged commit 45eee57 into crucialfelix:develop Apr 2, 2022
@andyzickler andyzickler deleted the remove-default-app-config branch January 1, 2023 21:10
MRoci added a commit to MRoci/django-su that referenced this pull request Apr 21, 2023
since the PR [289](crucialfelix/django-ajax-selects#289) has been merged
we can test with Django >= 4 with mainline `django-ajax-selects`.
PetrDlouhy pushed a commit to adamcharnock/django-su that referenced this pull request Apr 21, 2023
since the PR [289](crucialfelix/django-ajax-selects#289) has been merged
we can test with Django >= 4 with mainline `django-ajax-selects`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants