Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for debug objects. #70

Merged
merged 11 commits into from
Aug 10, 2022
Merged

Add support for debug objects. #70

merged 11 commits into from
Aug 10, 2022

Conversation

crud89
Copy link
Owner

@crud89 crud89 commented Aug 9, 2022

Describe the pull request

This PR implements support for various debug interfaces for both APIs. In Vulkan it adds support to name most object types. In DirectX12 it does the same and also adds debug markers for render passes, as long as the application is not running with an active debugger connected (i.e. Visual Studio). This is due to a limitation in the D3D12 debug layers, which will raise a warning, if the debug marker API is not called from PIX. It works fine, when connected to RenderDoc.

Related issues

Implements #15.

@crud89 crud89 added Priority: Medium A issue with normal priority. Type: Feature Request New feature or request. Type: Requirement An implementation is required before the next release. Module: Vulkan 🌋 The issue involves the Vulkan backend. Module: DX12 ❎ The issue involves the DX12 backend. labels Aug 9, 2022
@crud89 crud89 added this to the Alpha #03 milestone Aug 9, 2022
@crud89 crud89 self-assigned this Aug 9, 2022
@crud89 crud89 linked an issue Aug 9, 2022 that may be closed by this pull request
@crud89 crud89 marked this pull request as ready for review August 9, 2022 17:45
@crud89 crud89 merged commit 7ae2dd2 into main Aug 10, 2022
@crud89 crud89 deleted the debug-objects branch August 10, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: DX12 ❎ The issue involves the DX12 backend. Module: Vulkan 🌋 The issue involves the Vulkan backend. Priority: Medium A issue with normal priority. Type: Feature Request New feature or request. Type: Requirement An implementation is required before the next release.
Projects
Status: v0.3.1
Development

Successfully merging this pull request may close these issues.

Add support for debug objects.
1 participant