Fix for device rotation glitches #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test in more places). Try to resize during rotation animation [not working]
|
@cruffenach this is almost ready for a merge, just having trouble with that last task... This could be merged now if another issue is raised for the height not adjusting on rotation. |
|
Oh man I just found the problem. |
…parameters. Fixed incorrectly named CR'StatusBar'DefaultHeight value.
|
Ready for review and merge @cruffenach :) |
Conflicts: CRToast/CRToast.m
…nt: implementation wasn't needed.
Ashton-W
added a commit
that referenced
this pull request
Aug 4, 2014
Fix for device rotation glitches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After coming back to this again and again, I finally understand what the problem is: The UIWindow we show above the app must have the same frame as the screen. When the device is rotated, black squares are placed on all sides of the window during the rotation (the black you see in the corners). In our case our window was small and in the middle of the screen, so those black squares were being drawn over our interface :(
📦 ready for merge once all tasks complete: