Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height does not reflect NavBar height when it has a prompt #77

Open
onato opened this issue Jul 1, 2014 · 4 comments
Open

Height does not reflect NavBar height when it has a prompt #77

onato opened this issue Jul 1, 2014 · 4 comments
Labels

Comments

@onato
Copy link

onato commented Jul 1, 2014

If you set self.navigationItem.prompt the navigation bar increases in height. This is not taken into account by CRToast.

ios simulator screen shot 1 07 2014 10 16 23 pm

I guess this problem is also seen when rotating. See #73 (comment)

@cruffenach
Copy link
Owner

Damn, good one.

@Ashton-W
Copy link
Collaborator

Ashton-W commented Jul 7, 2014

The code has avoided looking for a UINavigationBar in the hierarchy, but I think this kind of issue will require it.

@Ashton-W Ashton-W added the bug label Jul 7, 2014
@onato
Copy link
Author

onato commented Jul 8, 2014

Perhaps you can use a controllers topLayoutGuide instead?

@dmiedema
Copy link
Contributor

@Ashton-W I created a branch that is able to account for this & updated the demo project with an option to add the prompt.

This does have to look in the hierarchy for a UINavigationController so this may not be the most ideal solution. Also I'm not sure if my solution will work in every instance of a prompt existing. It does seem to work for both portrait & landscape.

https://github.com/dmiedema/CRToast/tree/Navigation-Bar-Prompt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants