-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change in the path-matching functionality, along with corresponding README update. #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robison
force-pushed
the
change-path-matching
branch
2 times, most recently
from
November 28, 2019 21:19
ee1cf41
to
ea6cab9
Compare
robison
force-pushed
the
change-path-matching
branch
from
March 9, 2020 23:16
ea6cab9
to
2a3d4cd
Compare
|
Superseded by #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the following changes to make working with Daytona behavior a bit more intuitive:
VAULT_SECRETS_
withDAYTONA_SECRET_DESTINATION_
, the secret name discovered via a secrets walk in Vault is used as the suffix toDAYTONA_SECRET_DESTINATION_
to specify the output location. (This is the current behavior, and unchanged, but with tests now, and an updated/reworded README)VAULT_SECRET_
withDAYTONA_SECRET_DESTINATION_
to specify a direct secret path, the suffix name in these two envvars is used as the key to identify and pair them, instead of the secret name discovered in Vault. This allows for more intuitive behavior, and may simplify some workflows, especially those that have a lowercase secret key name in Vault, but require the use of (or disuse of) certain characters (.
in envvars come to mind).