Add a Starlark code generator #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try it out: ``` isopod generate testdata/clusterrolebinding.yaml ``` Works with yaml or python. The code generator uses the kubernetes parser to get `runtime.Object`s. Reflect and a recursive function is used to generate the python code. The test covers all code by generating an entire file.
jonnylangefeld
force-pushed
the
jlf/starlark-code-generator
branch
4 times, most recently
from
4a2aa30
to
492529b
Compare
jonnylangefeld
force-pushed
the
jlf/starlark-code-generator
branch
from
492529b
to
6ac67b3
Compare
jonnylangefeld
force-pushed
the
jlf/starlark-code-generator
branch
from
a22bb9a
to
ba73ec8
Compare
This was referenced May 20, 2020
cxuu
reviewed
May 20, 2020
jonnylangefeld
force-pushed
the
jlf/starlark-code-generator
branch
from
306c141
to
125c13e
Compare
the method in the previous commit didnt work, because the string slice was in a different order than the value slice. They had to be ordered at the same time. The solution now is to introduce a separate map, that maps from strinkKey => valueKey. Now its bullet proof.
cxuu
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try it out:
Works with yaml or json.
The code generator uses the kubernetes parser to get
runtime.Objects.Reflect and a recursive function is used to generate the starlark code.
The test covers all code by generating multiple files.
Fix #46
Supports CRD
Supports
kube.putfor now, so that's allk8sresources. Should supportkube.put_yamllater for custom resources