This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
Fix bug in helm chart when namespace != k-rail #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also bump version of helm chart
andyspiers
changed the title
|
@dustin-decker - any thoughts on this? It looks like a genuine fat-finger / 🦋 (bug). |
dustin-decker
approved these changes
Jun 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helm chart didn't produce a working admission webhook when installing in a namespace other than
k-railThis was because the service name and namespace name are transposed in the webhook configuration.
This PR corrects that.
Thanks!
Andy