Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to pass FilledPolygons an array of points arrays for many polygons? #288

Open
conrad opened this issue Dec 13, 2019 · 2 comments

Comments

@conrad
Copy link

conrad commented Dec 13, 2019

We're enjoying using this library a lot and hope to share how it's helping us run a fleet of robots. So, thank you :)

Something that could help our performance in the browser would be to allow setting an array of polygon points arrays for the points property in FilledPolygons. Our systems send us larger arrays of points for many polygons all of the same type or class, so it would be really helpful to be able to simply pass that array of arrays to the points property on one data object. Would that be possible?

@vidaaudrey
Copy link
Contributor

Hi @conrad, the instanced FilledPolygons is a nice feature to have. Should be straightforward to change the logic here to accept array of points and create triangles accordingly. We might not have the capacity to get to this until early January. Feel free to send a PR if you are interested in implementing it :)

@conrad
Copy link
Author

conrad commented Jan 10, 2020

Thanks, @vidaaudrey! We also haven't had a lot of bandwidth, but I'll be able to take a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants