POC Rename ef-open (Do not merge :-)) #229

markeaton123 · 2021-12-14T23:54:57Z

Ticket

PTP-1955

Details

This PR is a working POC illustrating the feasibility of using standard shell tools with little developer intelligence to effect the removal of ellation and most abbreviations thereof from the repo
Include any relevant details like:

Test results are included below

For posterity, command history can be found at https://wiki.tenkasu.net/display/CTO/Mark%27s+zsh+Fun - details on request

install.log
unittests.log
sample_execution_expected_failure.log

othiym23

The sed patterns used for this ended up creating a bunch of typos (I flagged the ones I spotted but I'm not confident I caught them all). If we were to do this for real, it would probably need to be done in a text editor that supports multi-file search and replace.
On its own this is not ready to merge even to this repo, because of the dependencies on other repos and the dependencies that other parts of our delivery and infrastructure management tools have back into the repo. I think it probably needs to be broken up into several PRs to split up the renaming of the tools (which other repos depend on) from reconfiguring to different S3 bucket and host names.
We need to either remove or update the copyright messages in the individual files. This is a matter for Legal to provide guidance on, but my preference would be to remove the copyright statements if at all feasible, potentially replacing them with a LICENSE for the repo as a whole.

othiym23 · 2021-12-16T00:11:17Z

README.md

@@ -74,5 +74,5 @@ The Jenkins CI pipeline will then recognize the new tag, build it, and publish i
 _DO NOT_ delete a tag and retag the same tag on a different commit.  This will not result in a replacement in PyPI, it will just make you sad.

 # License
-Copyright 2016-2017 Ellation, Inc.
+Copyright 2016-2017 Crunchyroll, Inc.


We should probably either update the dates to include 2016-2022, or do something like

Copyright 2016-2021 Ellation, Inc.
Copyright 2021-2022 Crunchyroll, Inc.

othiym23 · 2021-12-16T00:11:37Z

crfopen/crf_app_config_reader.py

@@ -1,5 +1,5 @@
 """
-Copyright 2016-2017 Ellation, Inc.
+Copyright 2016-2017 Crunchyroll, Inc.


Same as above re: copyright dates.

othiym23 · 2021-12-16T00:12:18Z

crfopen/crf_aws_resolver.py

@@ -1,5 +1,5 @@
 """
-Copyright 2016-2017 Ellation, Inc.
+Copyright 2016-2017 Crunchyroll, Inc.


Same as above re: copyright dates.

othiym23 · 2021-12-16T00:13:31Z

crfopen/crf_cf_diff.py

@@ -1,5 +1,5 @@
 """
-Copyright 2016-2018 Ellation, Inc.
+Copyright 2016-2018 Crunchyroll, Inc.


See above re: copyright dates.

othiym23 · 2021-12-16T00:13:57Z

crfopen/crf_check_config.py

@@ -9,7 +9,7 @@
  3 if some other error occurred


-Copyright 2016-2017 Ellation, Inc.
+Copyright 2016-2017 Crunchyroll, Inc.


See above re: copyright dates.

othiym23 · 2021-12-16T01:18:59Z

versioneer.py

-                             "TAG_PREFIX": cfg.tag_prefix,
-                             "PARENTDIR_PREFIX": cfg.parentdir_prefix,
+                             "TAG_PRCRFIX": cfg.tag_prefix,
+                             "PARENTDIR_PRCRFIX": cfg.parentdir_prefix,


Search & replace fail.

othiym23 · 2021-12-16T01:19:23Z

versioneer.py

@@ -1613,8 +1613,8 @@ def run(self):
                    f.write(LONG %
                            {"DOLLAR": "$",
                             "STYLE": cfg.style,
-                             "TAG_PREFIX": cfg.tag_prefix,
-                             "PARENTDIR_PREFIX": cfg.parentdir_prefix,
+                             "TAG_PRCRFIX": cfg.tag_prefix,


Search & replace fail.

othiym23 · 2021-12-16T01:19:36Z

versioneer.py

-                             "TAG_PREFIX": cfg.tag_prefix,
-                             "PARENTDIR_PREFIX": cfg.parentdir_prefix,
+                             "TAG_PRCRFIX": cfg.tag_prefix,
+                             "PARENTDIR_PRCRFIX": cfg.parentdir_prefix,


Search & replace fail.

othiym23 · 2021-12-16T01:20:22Z

versioneer.py

@@ -1714,8 +1714,8 @@ def do_setup():
        LONG = LONG_VERSION_PY[cfg.VCS]
        f.write(LONG % {"DOLLAR": "$",
                        "STYLE": cfg.style,
-                        "TAG_PREFIX": cfg.tag_prefix,
-                        "PARENTDIR_PREFIX": cfg.parentdir_prefix,
+                        "TAG_PRCRFIX": cfg.tag_prefix,


Search & replace fail.

othiym23 · 2021-12-16T01:20:35Z

versioneer.py

-                        "TAG_PREFIX": cfg.tag_prefix,
-                        "PARENTDIR_PREFIX": cfg.parentdir_prefix,
+                        "TAG_PRCRFIX": cfg.tag_prefix,
+                        "PARENTDIR_PRCRFIX": cfg.parentdir_prefix,


Search & replace fail.

markeaton123 · 2021-12-16T23:42:36Z

For sure, my use of sed was heavy-handed. OTOH, I was just as heavy handed in aggressively correcting the changes. FWIW, all of the typos were non-functional in nature, but annoying to be sure. It's actually really hard to make sure you're not overzealous in doing global replaces even with an editor that does support multi-file access, but I get your point. And, yes, I do know how to use PyCharm to do this :-)
The repo dependency is unfortunate. Devops will need to provide a rubric for the sequencing and that's beyond what I wanted to comment.
I've updated all of the copyrights. This is a larger issue than just the rename activity, I must say.

Anyway, there's lots of outdated conversations now - we can leave them as is or revisit this at another time.

Mark Eaton added 4 commits December 1, 2021 15:59

First pass of sed

90abcbf

First pass at renaming files

520868c

Fixed up Python dependencies

4521120

Add mock library

8aab1b7

markeaton123 requested review from othiym23, casspc, dlutsch and rsbano December 14, 2021 23:54

markeaton123 self-assigned this Dec 14, 2021

othiym23 suggested changes Dec 16, 2021

View reviewed changes

Mark Eaton added 8 commits December 16, 2021 10:38

Fix up copyrights

1f7e243

Fix overly greedly search and replace for EF -> CRF

c890f0c

Another overly aggressive search and replace

b0d37b6

Latest changes for overly-greedly search and replace

5f2c811

Yet a different variant of the copyright problem

aa651ea

Fix another legacy Jira URL

2f8db50

Greedy, greedy, greedy...

19bdc5b

Mostly copyright fixes and a few accidentally added files

9c5b6cc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

POC Rename ef-open (Do not merge :-)) #229

POC Rename ef-open (Do not merge :-)) #229

markeaton123 commented Dec 14, 2021

othiym23 left a comment

othiym23 Dec 16, 2021

othiym23 Dec 16, 2021

othiym23 Dec 16, 2021

othiym23 Dec 16, 2021

othiym23 Dec 16, 2021

othiym23 Dec 16, 2021

othiym23 Dec 16, 2021

othiym23 Dec 16, 2021

othiym23 Dec 16, 2021

othiym23 Dec 16, 2021

markeaton123 commented Dec 16, 2021

POC Rename ef-open (Do not merge :-)) #229

Are you sure you want to change the base?

POC Rename ef-open (Do not merge :-)) #229

Conversation

markeaton123 commented Dec 14, 2021

Ticket

Details

othiym23 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markeaton123 commented Dec 16, 2021