Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New infra compatibility updates #246

Merged
merged 5 commits into from
Sep 26, 2023
Merged

New infra compatibility updates #246

merged 5 commits into from
Sep 26, 2023

Conversation

dlutsch
Copy link
Contributor

@dlutsch dlutsch commented Sep 26, 2023

Description

Changes to allow ef-open to reference services deployed with serverless / k8s for the purpose of service to service communication.

  • Update the aws:ec2:security-group/security-group-id lookup to search by name tag if the sg name isn't found.
  • Add a "NoValue" default lookup value which will render to { "Ref": "AWS::NoValue" } if the lookup fails. This is a failsafe to prevent templates from failing to deploy if a lookup target doesn't exist yet in a given environment.
  • Adds a new {{ENV_NEW}} symbol which will resolve to the matching new env name, based on values from the ef_site_config. i.e.
  "alpha" -> "sbx"
  "proto" -> "dev"
  "staging" -> "stg"
  "prod" -> "prd" 
  • Removes the gitleaks github action. This was added a long time ago by security, but we do not appear to have an active license, and anyone involved with adding it has long since left the company.

Can this PR be merged / deployed at any time?

  • Yes
  • No, only at specific time (please specify below)
  • No, only after certain conditions are met (please specify below)

Timeframe/Conditions:

How was this tested?

Tested using the sg lookup "cr-pay-transaction-service-stg" which is a serverless framework created security group, which references a name tag, not the sg name directly.

@dlutsch dlutsch changed the title update sg lookup to include name tags New infra compatibility updates Sep 26, 2023
@dlutsch dlutsch merged commit b691563 into master Sep 26, 2023
2 checks passed
@dlutsch dlutsch deleted the sg_lookup branch September 26, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants