Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Market] Add mortgage mechanism for provider #151

Merged
merged 8 commits into from
Jun 9, 2020
Merged

[Market] Add mortgage mechanism for provider #151

merged 8 commits into from
Jun 9, 2020

Conversation

mmyyrroonn
Copy link
Member

@mmyyrroonn mmyyrroonn commented Jun 3, 2020 •
edited by badkk

@mmyyrroonn mmyyrroonn requested a review from badkk June 3, 2020 15:30
badkk
badkk reviewed Jun 8, 2020
View reviewed changes
cstrml/market/src/lib.rs Show resolved Hide resolved
cstrml/market/src/lib.rs Outdated Show resolved Hide resolved
cstrml/market/src/lib.rs Outdated Show resolved Hide resolved
@badkk badkk changed the title [Market] Add pledge function for provider [Market] Add mortgage mechanism for provider Jun 8, 2020
@badkk
Copy link
Member

badkk commented Jun 9, 2020

Talked offline, like bond operation in staking, we divided pledge into 3 actions:

  1. Using pledge to replace register;
  2. pledge_extra to add more mortgage;
  3. cut_pledge to allow provider do redemption;

mmyyrroonn
mmyyrroonn commented Jun 9, 2020
View reviewed changes
cstrml/market/src/lib.rs Outdated Show resolved Hide resolved
badkk
badkk reviewed Jun 9, 2020
View reviewed changes
cstrml/market/src/lib.rs Outdated Show resolved Hide resolved
cstrml/market/src/lib.rs Outdated Show resolved Hide resolved
@mmyyrroonn
Copy link
Member Author

User scenario

  • pledge
  • register
  • [Optional] pledge_extra/cut_pledge/register
  • [Deny] pledge again

badkk
badkk approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@badkk badkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

@mmyyrroonn mmyyrroonn merged commit 53628ae into crustio:master Jun 9, 2020
@mmyyrroonn mmyyrroonn deleted the market-mortgage branch June 9, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badkk badkk badkk approved these changes

@LowEntropyBody LowEntropyBody LowEntropyBody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Market] Provider mortgage
3 participants
@mmyyrroonn @badkk @LowEntropyBody