Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPoW] Onchain Crypto Stage III: replace x509 with wasm webpki #280

Merged
merged 8 commits into from
Oct 28, 2020
Merged

[MPoW] Onchain Crypto Stage III: replace x509 with wasm webpki #280

merged 8 commits into from
Oct 28, 2020

Conversation

mmyyrroonn
Copy link
Member

@mmyyrroonn mmyyrroonn commented Oct 27, 2020 •
edited

Working on #176

  • Fork five libs
    • ring
    • webpki
    • serde_json_no_std
    • serde_no_std
    • serde_derive_no_std
  • Remove verify_identity from api.rs
  • Support verify_identity in util.rs
  • Test
    • mock test
    • ./target/release/crust --dev --execution Wasm and use crust-api to register identity
    • build wasm runtime

@mmyyrroonn mmyyrroonn requested a review from badkk October 27, 2020 08:46
badkk
badkk requested changes Oct 27, 2020
View reviewed changes
cstrml/swork/src/utils.rs Outdated
};

let chain: Vec<&[u8]> = Vec::new();
let now_func = webpki::Time::from_seconds_since_unix_epoch(1573419050);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments for this number

cstrml/swork/src/utils.rs Outdated
Err(_) => return None,
};

let chain: Vec<&[u8]> = Vec::new();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More meaningful name?

badkk
badkk approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@badkk badkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmyyrroonn mmyyrroonn merged commit f9af567 into crustio:master Oct 28, 2020
@mmyyrroonn mmyyrroonn deleted the onchain-crypto-stage-3-x509 branch October 28, 2020 02:49
@badkk badkk changed the title [MPoW] Onchain crypto stage 3: replace x509 with wasm webpki [MPoW] Onchain Crypto Stage III: replace x509 with wasm webpki Oct 28, 2020
@badkk badkk mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badkk badkk badkk approved these changes

@LowEntropyBody LowEntropyBody LowEntropyBody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmyyrroonn @badkk @LowEntropyBody