Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Navigation bar does not respect dark mode #6

Closed
crutchcorn opened this issue Apr 11, 2020 · 3 comments
Closed

Navigation bar does not respect dark mode #6

crutchcorn opened this issue Apr 11, 2020 · 3 comments
Labels
blocked We're blocked upstream on a dependency we rely on

Comments

@crutchcorn
Copy link
Member

Currently, in dark mode, we do not change the color of the navbar.

Preview with the broken navbar

This is because we're blocked upstream:

thebylito/react-native-navigation-bar-color#23

The app repetitively crashes upon implementing the code that should work in https://github.com/crutchcorn/GitShark/tree/crashing_nav_bar

@crutchcorn crutchcorn added the blocked We're blocked upstream on a dependency we rely on label Apr 11, 2020
@coin3x
Copy link

coin3x commented Apr 14, 2020

The problem seems to be that Android doesn't support abbreviated color notations like #FFF.

react-native-navigation-bar-color internally uses Color.parseColor() from Android API.

From the Android docs:

Color.parseColor

Parse the color string, and return the corresponding color-int. If the string cannot be parsed, throws an IllegalArgumentException exception. Supported formats are:

  • #RRGGBB
  • #AARRGGBB

@crutchcorn
Copy link
Member Author

@coin3x that's a great observation! You might want to make a PR upstream that adds support to the package for tri-digit shorthand, as it seems to be stumping folks upstream even:

thebylito/react-native-navigation-bar-color#23

@crutchcorn
Copy link
Member Author

Closing this issue in favor of #9 (since having a transparent navbar solves the issue of a solid colored navbar not matching).

I will be leaving the branch up since it's linked upstream until such time that the upstream issue has been resolved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked We're blocked upstream on a dependency we rely on
Projects
None yet
Development

No branches or pull requests

2 participants