Miscellaneous minor bug fixes #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JustAGhost23
commented
Feb 24, 2024
JustAGhost23
commented
- Use fullNames instead of shortNames
- Add pptx mimeType to render PPT drawable for pptx files
- Remove bottom constraint for ImageView in forum attachment row
TTD has asked us to use fullNames of courses instead of shortNames as they only put in course IDs in shortName, hence the change was necessary
This change was made to keep consistency with the textView which is also not constrained to the barrier below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.