Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opens external links in a new tab #366

Merged
merged 3 commits into from Oct 28, 2020
Merged

Conversation

remigioamc
Copy link
Contributor

Thanks for contributing to the Hacktoberfest Swag List 馃槂 馃帀! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 馃帀
Tagging @crweiner to take a look. 馃憖

@netlify
Copy link

netlify bot commented Oct 27, 2020

Deploy preview for hacktoberfest-swag-list ready!

Built with commit 2959104

https://deploy-preview-366--hacktoberfest-swag-list.netlify.app

@remigioamc
Copy link
Contributor Author

This closes #361 based on this.

@codeclimate
Copy link

codeclimate bot commented Oct 28, 2020

Code Climate has analyzed commit 2959104 and detected 0 issues on this pull request.

View more on Code Climate.

@crweiner
Copy link
Owner

Woohoo! Thank you @remigioamc for this awesome contribution! 馃帀 馃帀 馃帀 I can't believe that I didn't see this before and this is much simpler than trying to get the Gem to work.

You're incredible and I hope you're having a great Hacktoberfest. Thanks again! 馃槃 馃巻

you rock

@crweiner crweiner added the hacktoberfest-accepted Approved for Hacktoberfest label Oct 28, 2020
@crweiner crweiner merged commit af21445 into crweiner:master Oct 28, 2020
This was referenced Oct 28, 2020
remigioamc added a commit to remigioamc/hacktoberfest-swag-list that referenced this pull request Oct 28, 2020
Merge pull request crweiner#366 from remigioamc/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Approved for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants