Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mkdocs.yml enables Attributes List #573

Merged
merged 4 commits into from Oct 1, 2022

Conversation

asi309
Copy link
Contributor

@asi309 asi309 commented Oct 1, 2022

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

@netlify
Copy link

netlify bot commented Oct 1, 2022

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit c975664
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/63389f9f5c7f1d00085fb37c
😎 Deploy Preview https://deploy-preview-573--hacktoberfest-swag-list.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Oct 1, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@crweiner
Copy link
Owner

crweiner commented Oct 1, 2022

Hello @asi309! 👋 Thank you for adding the extension, can you please fix the CodeFactor flags and add some tags to current links to make sure that they work?

@codeclimate
Copy link

codeclimate bot commented Oct 1, 2022

Code Climate has analyzed commit c975664 and detected 0 issues on this pull request.

View more on Code Climate.

@asi309
Copy link
Contributor Author

asi309 commented Oct 1, 2022

@crweiner I have fixed the codeclimate issue and added few tags to index.md and they are opening in new tab

@crweiner
Copy link
Owner

crweiner commented Oct 1, 2022

Beautiful job, @asi309! Thank you very much! I'll comb through and add the link attributes for the other links on the list, and add a reference in the Contributing.md doc.

Appreciate it! Happy Hacktoberfest! 🎉

@crweiner crweiner added the hacktoberfest-accepted Approved for Hacktoberfest label Oct 1, 2022
@crweiner crweiner merged commit e2b3adf into crweiner:master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Approved for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants