Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Clueless to Hacktoberfest swag listing #645

Closed
wants to merge 0 commits into from
Closed

feat: add Clueless to Hacktoberfest swag listing #645

wants to merge 0 commits into from

Conversation

kev-odin
Copy link
Contributor

@kev-odin kev-odin commented Oct 6, 2022

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

fixes #615

@ghost
Copy link

ghost commented Oct 6, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit 6fda4a7
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/633fa9ae5b52df0009d48265
😎 Deploy Preview https://deploy-preview-645--hacktoberfest-swag-list.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

docs/list.md Outdated
- No code/Low code:
- Most of the Neo4j docs, developer guides, and knowledge base articles have an `Edit This Page` link on the top right.
- Use this to help fix typos, clarify explanations, add code-examples and more.
- Clicking the `Edit This Page` link will open up a Github editor where you can make changes and open Pull Request.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing spaces

docs/list.md Outdated
@@ -316,6 +346,31 @@ Appwrite is a self-hosted backend-as-a-service platform that provides developers

### N

#### **Neo4j**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headers should be surrounded by blank lines

docs/list.md Outdated
@@ -316,6 +346,31 @@ Appwrite is a self-hosted backend-as-a-service platform that provides developers

### N

#### **Neo4j**
- **Swag**: Pixoo display
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

@codeclimate
Copy link

codeclimate bot commented Oct 7, 2022

Code Climate has analyzed commit 72bd462 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 3

View more on Code Climate.

@crweiner
Copy link
Owner

crweiner commented Oct 7, 2022

Hey @kev-odin! 👋 It looks like this PR is pulling from your master branch fork, which has entries for both Clueless and Neo4j. Also see your recently-opened PR #650, as that has Clueless in it as well. If you are making multiple entries, I'd prefer that they be all-in-one PR so that it's easier to review and will create fewer merge conflicts.

Speaking of conflicts, can you please resolve this current merge conflict and resolve the issues flagged by Code Climate?

Please ping me when you're done or if you have any questions! Thanks! 👍

@kev-odin
Copy link
Contributor Author

kev-odin commented Oct 7, 2022

@crweiner fixed the merge conflicts in #652. I must have rebased something by accident.

Should be resolved now. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ClueLess to the Hacktoberfest Swag List
2 participants