Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use markdown_link_attr_modifier Python Plugin #659

Merged
merged 4 commits into from Oct 7, 2022
Merged

Use markdown_link_attr_modifier Python Plugin #659

merged 4 commits into from Oct 7, 2022

Conversation

crweiner
Copy link
Owner

@crweiner crweiner commented Oct 7, 2022

This PR is to get the Python markdown_link_attr_modifier plugin working in MkDocs and Material to automatically write target="_blank" instead of having to add that in Kramdown style {:target="_blank"}

@ghost
Copy link

ghost commented Oct 7, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@netlify
Copy link

netlify bot commented Oct 7, 2022

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit 0d2144b
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/6340636db0738c0008f5fcef
😎 Deploy Preview https://deploy-preview-659--hacktoberfest-swag-list.netlify.app/contributing
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Oct 7, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d2144b
Status:🚫  Build failed.

View logs

1. Be sure you are looking to add something of substance to this project, not just spam PRs. PRs must meet the [Hacktoberfest Quality Standards](https://hacktoberfest.com/participation/){:target="\_blank"}.
2. Verify that you have read the [home page](index.md), and [Readme.md on GitHub](https://github.com/crweiner/hacktoberfest-swag-list/blob/master/README.md){:target="\_blank"}. You understand that this project is to connect maintainers with developers, not a way to get all the swag you can.
1. Be sure you are looking to add something of substance to this project, not just spam PRs. PRs must meet the [Hacktoberfest Quality Standards](https://hacktoberfest.com/participation/).
2. Verify that you have read the [home page](index.md), and [Readme.md on GitHub](https://github.com/crweiner/hacktoberfest-swag-list/blob/master/README.md). You understand that this project is to connect maintainers with developers, not a way to get all the swag you can.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordered list item prefix

@codeclimate
Copy link

codeclimate bot commented Oct 7, 2022

Code Climate has analyzed commit 0d2144b and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

View more on Code Climate.

@crweiner crweiner marked this pull request as ready for review October 7, 2022 17:37
@crweiner
Copy link
Owner Author

crweiner commented Oct 7, 2022

This new plugin will automatically add rel="noopener" target="_blank" to all links when converting from Markdown to HTML. 🎉 No need to add {:target="_blank"} after the Markdown URLs anymore!

This PR cleans up the repo by removing {:target="_blank"}, updates the Material theme for MkDocs, and updates the pip files to add the new dependences for the Python markdown_link_attr_modifier plugin. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant