Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opinion and suggestions #3

Closed
NoraYashika opened this issue Dec 15, 2023 · 6 comments
Closed

Opinion and suggestions #3

NoraYashika opened this issue Dec 15, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@NoraYashika
Copy link

NoraYashika commented Dec 15, 2023

Hiya @crwntec,
I saw your application and was immediately baffled. Since I will move to Germany soon, it'll come in handy...
You said you are all ears for suggestions and I have a few.

  1. Language support for different languages
  2. route planner (will need some explanation, I'll do that below
  3. Accessibility features for people with disabilities
  4. Amenities list, like does the train provide an internet connection or like that, if possible

route planner??

I mean by that an option to select a series of stops, in order to chain them together, for example Berlin to Frankfurt with a stop at Magdeburg. The user would select "Berlin, Madgeburg, Frankfurt" (just as an example) in a seperate (prob'ly, i dunno?) route selection window or something. I hope you know, what I mean.

I hope there are some good ideas.

anyways, hang in there and get the 400h.
TTYS
~Nora

@crwntec
Copy link
Owner

crwntec commented Dec 16, 2023

Hey Nora,
I really appreciate your interest in this project. Regarding your suggestions I have a few things to say:

1. Language support

Implementing this would be fairly easy because there are librarys for that and HAFAS natively supports different languages for hints and remarks

2. Route planner

Route planning is also supported by the HAFAS client but involves much more works as it requires building a whole new page for it. And the problem with adding a new page is the lack of navigation. I currently don´t have any kind of navigation bar that would allow you to switch between departure and route mode and the UI isn´t really designed for that either. But if you have any suggestions on where to implement something like that, feel free to let me know.

3. Accessibility

I don´t have any idea on how to make something like this and I doubt that there are many people that would profit from it, but if I have time I´ll look into it

4. Amenities

This is something I had on my mind since I started working on the train order feature, because the API also has information on that, but I kinda forgot about it and moved on, because in my experience, almost all trains from DB Fernverkehr now have functioning wifi. However I´m probably going to implement it in a feature version.

Thanks for you interest!
crwntec

@crwntec crwntec self-assigned this Dec 16, 2023
@crwntec crwntec added the enhancement New feature or request label Dec 16, 2023
@crwntec crwntec mentioned this issue Dec 16, 2023
18 tasks
@crwntec
Copy link
Owner

crwntec commented Dec 16, 2023

Update 4.5.0

You should now be able to change the applications language via the settings menu. However I could only translate about 90% because IRIS encodes its messages with numbers and I have a JSON file to parse those and as I´ve not translated this file yet you´d still need a translator to find out why a train is delayed for example.

crwntec

Btw thanks for the star :)

@NoraYashika
Copy link
Author

Hey @crwntec,
thanks for adding in the translation. If you want, I can help you translate it. I thought of a section basically between frontend and backend. In this section is an API that catches everything, you want to display and translates it to a selected language.
Let me know what you think and if it is okay for you, I'd help you to make this program and tell you where to integrate it.

Let me know and TTYS,
~ Nora

@crwntec
Copy link
Owner

crwntec commented Dec 18, 2023

That would be awesome!

@NoraYashika
Copy link
Author

Hello again,
should I do it in a specific language? I would do it in C/C++ for speed and efficiency reasons and output it into a json file. It would need some implementation work on both frontend and backend but maybe I could even use the system I am making for my repo "QORA AI". Even though it requires a certain amount of work, it would be the most efficient way and while I am working on my AIs translation system, I should just need to translate it to your desired language. It doesn't need to be C++, it could also be, i. e.: JavaScript, but keep in mind, that I need to learn the language, depending on your choice.
~Nora

@crwntec
Copy link
Owner

crwntec commented Dec 19, 2023

Hi,
What I need is a translated messageCategories.json file so that I can switch between both files based on the selected language. So a simple program that translates all of that while keeping the structure would be really useful. I don't mind if it's in C or C++. Thanks in advance 👍
crwntec

@crwntec crwntec closed this as completed Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants