[Vite Plugin] Fix vite manifest location #841

ale-ben · 2023-12-06T17:02:13Z

This should solve #836

For production: after running vite build, a .vite/manifest.json file will be generated alongside other asset files.

Right now, when building, the plugin tries to find a vite manifest without considering the .vite folder:

chrome-extension-tools/packages/vite-plugin/src/node/plugin-webAccessibleResources.ts

Lines 105 to 108 in 20faa15

    
           const viteManifest = parseJsonAsset<ViteManifest>( 
        
             bundle, 
        
             'manifest.json', 
        
           )

As suggested here (#836 (comment)), replacing manifest.json with .vite/manifest.json solves the build error.

…nifest is in .vite/manifest.json. Fixing bug that prevented building

changeset-bot · 2023-12-06T17:02:16Z

🦋 Changeset detected

Latest commit: cf0758b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@crxjs/vite-plugin	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2023-12-06T17:02:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
vite-plugin-docs	⬜️ Ignored (Inspect)	Visit Preview		Jan 10, 2024 11:04pm

kaminskypavel · 2023-12-17T13:18:00Z

any plans on merging?

ale-ben · 2023-12-18T15:14:45Z

Would be nice to have any feedback on this...
If there are problems I can fix them but I would like to see it merged as well

kaminskypavel · 2023-12-18T15:25:23Z

Would be nice to have any feedback on this... If there are problems I can fix them but I would like to see it merged as well

this will allow upgrading to Vite@5, am I correct?

ale-ben · 2023-12-18T15:28:33Z

Honestly, I have no idea...
I just had the same problems described here #836 and, after reading a bit of Vite documentation, I identified where the problem was and fixed it (I think so at least)

ale-ben · 2023-12-19T08:58:48Z

@kaminskypavel Just noticed something, I am already using Vite@5...

kaminskypavel · 2023-12-19T22:21:23Z

@jacksteamdev @AmySteam what do you guys think?

nandanito · 2023-12-20T09:13:22Z

@ale-ben I'm still getting the same following error, while using vite@5.0.10 with vite-plugin@2.0.0-beta.21.
[crx:web-accessible-resources] TypeError: OutputBundle["manifest.json"] is undefined.

The upgrading to 5.0.x is not working.

ale-ben · 2023-12-20T09:28:43Z

@nandanito this is the project I'm testing with.

Just to be on the safe side, I rebuilt the vite plugin from my main branch and manually put it in my project. This is the build outputs:
Vite plugin:

My project (with dist folder manually replaced with build output):

Can you provide an example of when it doesn't work?

nandanito · 2023-12-27T04:58:43Z

@ale-ben Here is the repo where it is not working.

I think merging your commit in the next release might solve the issue (also discussed here).

jacksteamdev

@ale-ben Thanks for the PR! Awesome research and deduction to get this working with Vite 5! 🌟

It looks like this is a breaking change for Vite 4, but maybe that's not a big deal? We could release this in one of two ways:

Major version bump and only support Vite 5... This will require updating the tests to use Vite 5
Make this PR backwards compatible

What makes the most sense to everyone?

kaminskypavel · 2024-01-07T20:24:19Z

IMHO, breaking changes should be a last resort, especially if this can be avoided with a simple if/then statement.

…

On Sun, Jan 7, 2024, 8:22 PM Jack Steam ***@***.***> wrote: ***@***.**** commented on this pull request. @ale-ben <https://github.com/ale-ben> Thanks for the PR! Awesome research and deduction to get this working with Vite 5! 🌟 It looks like this is a breaking change for Vite 4, but maybe that's not a big deal? We could release this in one of two ways: 1. Major version bump and only support Vite 5+ 2. Make this PR backwards compatible What makes the most sense to everyone? I'm going to promote the beta to latest on NPM in the next few weeks, so maybe option one is most maintainable option. — Reply to this email directly, view it on GitHub <#841 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAOLIB6EOULOHZW6OT5DWDYNLRXJAVCNFSM6AAAAABAJWPOLWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBXHA2TCMJXGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ale-ben · 2024-01-08T17:09:27Z

@kaminskypavel I Agree on the braking change thing. Didn't realize that was a breaking change between 4 and 5...

chrome-extension-tools/packages/vite-plugin/src/node/plugin-webAccessibleResources.ts

Lines 105 to 108 in 20faa15

    
           const viteManifest = parseJsonAsset<ViteManifest>( 
        
             bundle, 
        
             'manifest.json', 
        
           )

The idea is to have this load 'manifest.json' if Vite is v4 and '.vite/manifest.json' if vite is v5, correct?

I'll finish testing the required fix and then I'll push it

ale-ben · 2024-01-08T17:23:28Z

This should provide compatibility for both Vite <=4 and Vite >4.
Let me know if I missed something.

Reviewing my old commit and updating changeset I noticed that I previously considered this change as a patch. Is this correct or should it be bumped to minor?
Is this considered a new feature or a bug? 😅

kaminskypavel · 2024-01-09T22:59:04Z

@jacksteamdev can we merge this? it is blocking vite upgrade

jacksteamdev · 2024-01-10T21:35:01Z

It seems like the tests are broken, but I don't think it's this PR. I'm working to fix them now, will update later.

jacksteamdev

LGTM!

[main] Fix vite manifest location According to documentation, vite ma…

d963a09

…nifest is in .vite/manifest.json. Fixing bug that prevented building

[main] Added changeset

9d70d06

This comment was marked as off-topic.

Sign in to view

Merge branch 'main' into main

ccada4f

vercel bot deployed to Preview January 7, 2024 18:01 View deployment

jacksteamdev reviewed Jan 7, 2024

View reviewed changes

jacksteamdev self-assigned this Jan 7, 2024

ale-ben added 2 commits January 8, 2024 18:18

[main] Determine vite manifest path based on vite version

505f060

[main] Merge branch 'main' of github.com:ale-ben/chrome-extension-tools

2fa1b00

vercel bot deployed to Preview January 8, 2024 17:19 View deployment

ale-ben added 2 commits January 8, 2024 18:19

Merge branch 'main' into main

f34a9f6

[main] Formatting issue

460770a

ale-ben requested a review from jacksteamdev January 8, 2024 17:26

[main] Update changelog to reflect new changes

6e89abc

Merge branch 'main' into main

cf0758b

jacksteamdev approved these changes Jan 10, 2024

View reviewed changes

jacksteamdev merged commit 48d8c68 into crxjs:main Jan 10, 2024
4 checks passed

This comment was marked as spam.

Sign in to view

ale-ben mentioned this pull request Jan 22, 2024

Build error [crx:web-accessible-resources] TypeError: OutputBundle["manifest.json"] is undefined #836

Closed

2 tasks

AmySteam mentioned this pull request Jan 29, 2024

Use vite 5 #835

Closed

kaminskypavel mentioned this pull request Feb 1, 2024

[crx:content-script-resources] Error: vite manifest is missing #846

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Vite Plugin] Fix vite manifest location #841

[Vite Plugin] Fix vite manifest location #841

ale-ben commented Dec 6, 2023

changeset-bot bot commented Dec 6, 2023 •

edited

Loading

vercel bot commented Dec 6, 2023 •

edited

Loading

kaminskypavel commented Dec 17, 2023

ale-ben commented Dec 18, 2023 •

edited

Loading

kaminskypavel commented Dec 18, 2023

ale-ben commented Dec 18, 2023

ale-ben commented Dec 19, 2023

kaminskypavel commented Dec 19, 2023

nandanito commented Dec 20, 2023

ale-ben commented Dec 20, 2023 •

edited

Loading

This comment was marked as off-topic.

nandanito commented Dec 27, 2023

jacksteamdev left a comment •

edited

Loading

kaminskypavel commented Jan 7, 2024 via email

ale-ben commented Jan 8, 2024 •

edited

Loading

ale-ben commented Jan 8, 2024 •

edited

Loading

kaminskypavel commented Jan 9, 2024

jacksteamdev commented Jan 10, 2024

jacksteamdev left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

	const viteManifest = parseJsonAsset<ViteManifest>(
	bundle,
	'manifest.json',
	)

[Vite Plugin] Fix vite manifest location #841

[Vite Plugin] Fix vite manifest location #841

Conversation

ale-ben commented Dec 6, 2023

changeset-bot bot commented Dec 6, 2023 • edited Loading

🦋 Changeset detected

vercel bot commented Dec 6, 2023 • edited Loading

kaminskypavel commented Dec 17, 2023

ale-ben commented Dec 18, 2023 • edited Loading

kaminskypavel commented Dec 18, 2023

ale-ben commented Dec 18, 2023

ale-ben commented Dec 19, 2023

kaminskypavel commented Dec 19, 2023

nandanito commented Dec 20, 2023

ale-ben commented Dec 20, 2023 • edited Loading

This comment was marked as off-topic.

nandanito commented Dec 27, 2023

jacksteamdev left a comment • edited Loading

Choose a reason for hiding this comment

kaminskypavel commented Jan 7, 2024 via email

ale-ben commented Jan 8, 2024 • edited Loading

ale-ben commented Jan 8, 2024 • edited Loading

kaminskypavel commented Jan 9, 2024

jacksteamdev commented Jan 10, 2024

jacksteamdev left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

changeset-bot bot commented Dec 6, 2023 •

edited

Loading

vercel bot commented Dec 6, 2023 •

edited

Loading

ale-ben commented Dec 18, 2023 •

edited

Loading

ale-ben commented Dec 20, 2023 •

edited

Loading

jacksteamdev left a comment •

edited

Loading

ale-ben commented Jan 8, 2024 •

edited

Loading

ale-ben commented Jan 8, 2024 •

edited

Loading