Improve CFlashMenuObject::UpdateNetwork #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoveCFlashMenuObject::UpdateNetwork
function, which callssetNetwork
Flash function on frame. Does it actually do something other than showing no connection symbol in multiplayer lobby? @griseranerUpdate: Use our own
ServerBrowser::LastRequestSucceeded
instead of problematicINetwork::HasNetworkConnectivity
.This fixes no connection symbol always shown in multiplayer lobby under Linux 馃惂, where
INetwork::HasNetworkConnectivity
always returns false when there's no recent network channel activity. In this case, it does some questionable checks of network adapters via Windows API. Definitely not something we want in main thread.INetwork::HasNetworkConnectivity
is also called on frame inCHUD::OnPostUpdate
, but that one should be fine because it's called only in-game and only whengEnv->bMultiplayer
is true. Therefore, network channel activity is there and it returns quickly without calling potentially blocking Windows API functions.Thanks to Furyaner for pointing out that
INetwork::HasNetworkConnectivity
is the culprit here. 馃檪