Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some memory bugs in dset_setstr and to_cstrs #37

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Fix some memory bugs in dset_setstr and to_cstrs #37

merged 1 commit into from
Jun 8, 2023

Conversation

hsnyder
Copy link
Contributor

@hsnyder hsnyder commented Jun 7, 2023

No description provided.

@hsnyder hsnyder requested a review from nfrasser June 7, 2023 17:45
@vercel
Copy link

vercel bot commented Jun 7, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cryosparc-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2023 5:48pm

nfrasser
nfrasser approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@nfrasser nfrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Harris, great catch!

cryosparc/core.pyx Show resolved Hide resolved
cryosparc/include/cryosparc-tools/dataset.h Show resolved Hide resolved
@hsnyder hsnyder merged commit f381c12 into develop Jun 8, 2023
5 of 6 checks passed
@hsnyder hsnyder deleted the fix-tocstrs branch June 8, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfrasser nfrasser nfrasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsnyder @nfrasser