Add :update-article-fn to customize parsed page/..

[holyjak]

Allow users to supply a function run on every parsed page/post to
update it.

Example uses:

• support for a custom :slug metadata in a post to override the defaul
  uri
• post-process the HTML to add self-links to every heading

NOTE

I struggled to find a good name for "post or page". In the end I have fallen back on the HTML standard and adopted the name it uses for the "main content", i.e. "article". Any better ideas?

NOTE 2

Notice that while extend-params-fn runs very late in the process, this runs very early so it can modify the base data used to create the various site data such as posts and posts-by-tags, while extend-params-fn would need to modify all the places where e..g a particular post is used.

[lacarmen]

I have fallen back on the HTML standard and adopted the name it uses for the "main content", i.e. "article". Any better ideas?

Let's leave it at that, naming is hard 😆.

Will you update the docs site again? A couple of examples that illustrates the flexibility/power this adds would be great!

[holyjak]

That's the plan, after this is merged. Thanks!

…

On Mon, 9 Dec 2019, 17:02 Carmen La, ***@***.***> wrote: I have fallen back on the HTML standard and adopted the name it uses for the "main content", i.e. "article". Any better ideas? Let's leave it at that, naming is hard 😆. Will you update the docs site again? A couple of examples that illustrates the flexibility/power this adds would be great! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#130?email_source=notifications&email_token=AAEYSPQH4GDNWARLWYKVBCDQXZTYPA5CNFSM4JYG6DP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGJWD5Q#issuecomment-563306998>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYSPVYKQ7GW3CFJJ2UQQTQXZTYPANCNFSM4JYG6DPQ> .

[holyjak]

DON'T MERGE pls

I realized it would be better to pass also config to the function so I will add that (so that we have access e.g. to blog-prefix in in)

[holyjak]

Ready to merge.

I have updated it to send also the config to the function and to make it possible to return nil from the fn to exclude the article from the blog.

[holyjak]

See cryogen-project/cryogen-docs#27 for the corresponding docs change.

[lacarmen]

Looks great -- good call on passing in the config and returning nil to exclude articles :) Will push out new versions now!

[lacarmen]

And thank you again for all the great features you've been adding!

[lacarmen]

Oh, this can't be identity because it's called with 2 args, but I can fix it :)

[holyjak]

My bad, thank you!

…

On Tue, Dec 10, 2019 at 3:36 PM Carmen La ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/cryogen_core/compiler.clj <#130 (comment)> : > ([] (compile-assets {})) - ([overrides] + ([{:keys [extend-params-fn update-article-fn] + :or {extend-params-fn (fn [params _] params) + update-article-fn identity} Oh, this can't be identity because it's called with 2 args, but I can fix it :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#130?email_source=notifications&email_token=AAEYSPVPMS55QA32UAJYKSLQX6SPNA5CNFSM4JYG6DP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOUZINA#pullrequestreview-329880628>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYSPQL7O3FAHT72MIM5STQX6SPNANCNFSM4JYG6DPQ> .