Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for deps tools instead of lein #221

Merged
merged 1 commit into from Nov 27, 2020
Merged

Support for deps tools instead of lein #221

merged 1 commit into from Nov 27, 2020

Conversation

holyjak
Copy link
Contributor

@holyjak holyjak commented Oct 30, 2020

With this change you can use clj-new
(or still lein new) and then use the
clojure CLI instead of leiningen to build/
serve the site.

An advantage is that it is possible to switch
to versions of libraries based on local paths or
git URLs and SHAs.

@holyjak
Copy link
Contributor Author

holyjak commented Oct 30, 2020

I have no experience with lein new so I do not know how to test the changes. Any guidance welcome!

@bombaywalla
Copy link
Member

Thanks for this PR.

I tested to check whether the lein and clj versions generate the same HTML files, by doing the following:

git clone https://github.com/holyjak/cryogen
cd cryogen
git checkout --track origin/feat/deps-edn
lein new cryogen foobar
cd foobar
lein run
mv public public-lein
clj -M:build
diff -r public public-lein

The results were the same (except for timestamps).

@bombaywalla
Copy link
Member

bombaywalla commented Nov 22, 2020

Would you please make the following changes to this PR.

  1. Add .lein-failures to the .gitignore file. Might also want to add the other lein-related ignore lines.
  2. Add the clj commands to the README.md in the appropriate places. clj -M:build near the lein run and clj -X:serve near the lein ring server.

@bombaywalla
Copy link
Member

I'd be okay merging this PR with the above changes.

Separately, wondering whether it might be a good idea to use the lein-tools-deps plugin so that there is only one place to update any dependencies. Currently, if any dependencies change, they will need to be updated in the generated project.clj and in the deps.edn.

With this change you can use clj-new
(or still lein new) and then use the
clojure CLI instead of leiningen to build/
serve the site.

An advantage is that it is possible to switch
to versions of libraries based on local paths or
git URLs and SHAs.
@holyjak
Copy link
Contributor Author

holyjak commented Nov 27, 2020

Thanks a lot! Done.

I am not sure how well the lein-tools-deps plugin works and did not want to risk causing any problems.

@bombaywalla
Copy link
Member

Agree on lein-tools-deps for now.

@bombaywalla bombaywalla merged commit 6e9fd4d into cryogen-project:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants