Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(base): update base grafana image version #16

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Oct 17, 2022

Related to cryostatio/cryostat#1118
Depends on #15

@andrewazores andrewazores added backport build chore Refactor, rename, cleanup, etc. labels Oct 17, 2022
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any known compatibility issues with this version bump? Downstream is stuck with 7.x for the time being.

@andrewazores
Copy link
Member Author

Nothing I've seen, it appears to just plug-and-play to the extent that we're using Grafana.

@andrewazores
Copy link
Member Author

I'm fine with holding off and not backporting this to the 2.2 release branch, though.

@andrewazores
Copy link
Member Author

@ebaron any further thoughts? Merge without backport perhaps?

@ebaron
Copy link
Member

ebaron commented Nov 4, 2022

@ebaron any further thoughts? Merge without backport perhaps?

I think merge without backport is probably safest. We could bump the 2.2 version to 7.5.17, which seems like the last 7 release.

@andrewazores
Copy link
Member Author

Sounds good.

@andrewazores andrewazores merged commit 5fae793 into cryostatio:main Nov 16, 2022
@andrewazores andrewazores deleted the baseimage branch November 16, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build chore Refactor, rename, cleanup, etc.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants