Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rh-jmc-team#43 broke unit tests #45

Closed
tabjy opened this issue Oct 15, 2019 · 1 comment · Fixed by #46
Closed

rh-jmc-team#43 broke unit tests #45

tabjy opened this issue Oct 15, 2019 · 1 comment · Fixed by #46

Comments

@tabjy
Copy link
Contributor

tabjy commented Oct 15, 2019

PR rh-jmc-team#43 modified error strings in implementations, but not in tests.

com.redhat.rhjmc.containerjfr.commands.internal.ConnectCommandTest > shouldNotValidateNull() FAILED
    org.mockito.exceptions.verification.ArgumentsAreDifferent at ConnectCommandTest.java:84

com.redhat.rhjmc.containerjfr.commands.internal.ConnectCommandTest > shouldNotValidateEmptyString() FAILED
    org.mockito.exceptions.verification.ArgumentsAreDifferent at ConnectCommandTest.java:90

com.redhat.rhjmc.containerjfr.commands.internal.ConnectCommandTest > shouldExpectOneArg() FAILED
    org.mockito.exceptions.verification.ArgumentsAreDifferent at ConnectCommandTest.java:67

com.redhat.rhjmc.containerjfr.commands.internal.ConnectCommandTest > shouldNotValidateInvalidIdentifiers(String)[1] FAILED
    org.mockito.exceptions.verification.ArgumentsAreDifferent at ConnectCommandTest.java:78

com.redhat.rhjmc.containerjfr.commands.internal.ConnectCommandTest > shouldNotValidateInvalidIdentifiers(String)[2] FAILED
    org.mockito.exceptions.verification.ArgumentsAreDifferent at ConnectCommandTest.java:78

com.redhat.rhjmc.containerjfr.commands.internal.ConnectCommandTest > shouldNotValidateInvalidIdentifiers(String)[3] FAILED
    org.mockito.exceptions.verification.ArgumentsAreDifferent at ConnectCommandTest.java:78

417 tests completed, 6 failed
testsuite com.redhat.rhjmc.containerjfr.commands.internal.SaveRecordingCommandTest:
  testcase com.redhat.rhjmc.containerjfr.commands.internal.ConnectCommandTest > shouldNotValidateNull(): Argument(s) are different! Wanted:
    cw.println(
        "Expected one argument: host name/URL"
    );
    -> at com.redhat.rhjmc.containerjfr.core.tui.ClientWriter.println(ClientWriter.java:11)

> Task :test FAILED

This is really trivial though.
@andrewazores
Copy link
Member

Thanks for catching this, I'll fix it momentarily.

andrewazores referenced this issue in andrewazores/cryostat Oct 15, 2019
@andrewazores
Correct unit test assertions
5af8417 
Strings printed by ConnectCommand on invalid input were changed but the
tests not modified to match.

Fixes #45
@andrewazores andrewazores mentioned this issue Oct 15, 2019
Merged
andrewazores added a commit that referenced this issue Oct 15, 2019
@andrewazores
Correct unit test assertions (#46)
b6eb0d7 
Strings printed by ConnectCommand on invalid input were changed but the
tests not modified to match.

Fixes #45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct unit test assertions andrewazores/cryostat
2 participants
@andrewazores @tabjy