Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rules): implement initialDelay #1015

Merged
merged 1 commit into from
Jul 5, 2022
Merged

feat(rules): implement initialDelay #1015

merged 1 commit into from
Jul 5, 2022

Conversation

andrewazores
Copy link
Member

Fixes #1014
Depends on cryostatio/cryostat-web#476

See issue and -web PR for more description.

@andrewazores andrewazores added the feat New feature or request label Jun 30, 2022
@andrewazores andrewazores mentioned this pull request Jun 30, 2022
Merged
jan-law
jan-law reviewed Jul 4, 2022
View reviewed changes
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Does this feature need documentation?

repeated-integration-tests.bash Show resolved Hide resolved
hareetd
hareetd approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions github-actions bot removed the dependent label Jul 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

This PR/issue depends on:

@andrewazores andrewazores merged commit 9daf5a6 into cryostatio:main Jul 5, 2022
@andrewazores andrewazores deleted the rule-initialdelay branch July 5, 2022 18:58
@andrewazores andrewazores mentioned this pull request Jul 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-law jan-law jan-law left review comments

@hareetd hareetd hareetd approved these changes

Assignees

@kucollin kucollin

Labels
feat New feature or request needs-documentation
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Add initialDelay to Automated Rule definitions
4 participants
@andrewazores @hareetd @jan-law @kucollin