Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jwt): use stored credentials when available #1025

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix(jwt): use stored credentials when available #1025

merged 1 commit into from
Jul 20, 2022

Conversation

andrewazores
Copy link
Member

Fixes #1024

hareetd
hareetd approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@hareetd hareetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

jan-law
jan-law approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@jan-law jan-law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andrewazores andrewazores force-pushed the jwt-jmxauth-storedcredentials branch from 038158e to b65b5a2 Compare July 20, 2022 00:47
@andrewazores andrewazores merged commit 7b34f46 into cryostatio:main Jul 20, 2022
@andrewazores andrewazores deleted the jwt-jmxauth-storedcredentials branch July 20, 2022 12:04
@jan-law jan-law mentioned this pull request Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hareetd hareetd hareetd approved these changes

@jan-law jan-law jan-law approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] JWT creation still expects client to passthrough jmxauth claim
3 participants
@andrewazores @hareetd @jan-law