Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(notifications): refactor for simplicity #1027

Merged
merged 3 commits into from
Jul 27, 2022
Merged

chore(notifications): refactor for simplicity #1027

merged 3 commits into from
Jul 27, 2022

Conversation

andrewazores
Copy link
Member

Related to #1020
Related to #921

  • chore(notifications): bind listeners at build time
  • chore(messaging): remove unused WsMessage class
  • chore(messaging): ws server receives messages via internal notification listener

@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Jul 27, 2022
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. and removed chore Refactor, rename, cleanup, etc. labels Jul 27, 2022
maxcao13
maxcao13 approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@maxcao13 maxcao13 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, no complaints and it all makes sense.

@andrewazores andrewazores merged commit 4cc283c into cryostatio:main Jul 27, 2022
@andrewazores andrewazores deleted the notification-listener-refactor branch July 27, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcao13 maxcao13 maxcao13 approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewazores @maxcao13