Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(itest): use standard external image version, make JDP poll configurable #1069

Merged
merged 4 commits into from
Sep 19, 2022
Merged

test(itest): use standard external image version, make JDP poll configurable #1069

merged 4 commits into from
Sep 19, 2022

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Sep 15, 2022 •
edited

Fixes #1068

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. test labels Sep 15, 2022
@andrewazores andrewazores force-pushed the itest-cleanup branch 3 times, most recently from 2af38db to 7f27f35 Compare September 15, 2022 19:56
@andrewazores andrewazores changed the title test(itest): use standard external image version, reduce poll times test(itest): use standard external image version, make JDP poll configurable Sep 15, 2022
@andrewazores andrewazores marked this pull request as ready for review September 15, 2022 20:15
lkonno
lkonno approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@lkonno lkonno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed. Checking the files, they are ok for me.

maxcao13
maxcao13 approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

@andrewazores andrewazores merged commit 7076cca into cryostatio:main Sep 19, 2022
@andrewazores andrewazores deleted the itest-cleanup branch September 19, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcao13 maxcao13 maxcao13 approved these changes

@lkonno lkonno lkonno approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. test
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Clean up itests to use standard external target container image, improve discovery poll times
3 participants
@andrewazores @maxcao13 @lkonno