fix(archives): fix recording deletion notifications do not update All-Archives view and fixed README typo #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
approved these changes
Oct 5, 2022
andrewazores
reviewed
Oct 6, 2022
| @@ -150,7 +150,9 @@ private void performArchival() throws InterruptedException, ExecutionException, | |||
| } | |||
|
|
|||
| private void pruneArchive(String recordingName) throws Exception { | |||
| recordingArchiveHelper.deleteRecording(recordingName).get(); | |||
| recordingArchiveHelper | |||
| .deleteRecording(serviceRef.getServiceUri().toString(), recordingName) | |||
There was a problem hiding this comment.
For a potential future refactor, should this first String targetId/connectUrl parameter be replaced with the whole ServiceRef to signify the sourceTarget? Only the connectUrl or jvmId is probably actually relevant, but it gives the option to use either of those as well as provides some compile-time type safety to guard against accidents like this one.
andrewazores
approved these changes
Oct 6, 2022
andrewazores
force-pushed
the
notification-bug
branch
from
faf3891
to
5107493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1098
Fixes #1023
Fixes cryostatio/cryostat-web#536
Just missed one more Periodic Archiver method change, oops.