fix(discovery): leave Custom Targets enabled when builtins are disabled #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1113
- use non-sa user by default for h2 setupsis not directly related to this PR but comes from discussions here:cryostatio/cryostat-operator#474 (comment)
In describing how things worked I realized I had left
sa(system administrator) as the default JDBC user, which was not intentional and is not necessary. Even for the H2 database scenarios,Cryostat should not require the use of a system administrator account.
To test, try
CRYOSTAT_DISABLE_BUILTIN_DISCOVERY=true sh smoketest.shbefore and after this PR. In either case, JDP targets should not be discovered, only the quarkus-test targets that self-publish via the discovery plugin API. With this PR applied you should also be able to define custom targets either through the web-client or by API request, whereas without this PR applied this functionality will be broken and defining a custom target will appear to be a no-op (200 success status code but not notification and no custom target visible in UI).